[PATCH] D36816: [XRay][compiler-rt] Support sled versioning for custom event sleds

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 22 20:18:05 PDT 2017


dberris marked 2 inline comments as done.
dberris added inline comments.


================
Comment at: lib/xray/xray_trampoline_x86_64.S:205
   .cfi_startproc
-	subq $16, %rsp
-	.cfi_def_cfa_offset 24
-	movq %rbp, 8(%rsp)
-	movq %rax, 0(%rsp)
+	SAVE_REGISTERS
 
----------------
pcc wrote:
> Without backend support I'd expect you to need to realign the stack here. You can see how to do that by compiling any C function with `-mstackrealign`.
Awesome stuff, thanks @pcc!


https://reviews.llvm.org/D36816





More information about the llvm-commits mailing list