[PATCH] D37028: [IRBuilder] Only emit alias scop metadata for arrays, but not scalars

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: lib/CodeGen/IRBuilder.cpp:65
+  // be handled easily by basicaa.
+  std::vector<ScopArrayInfo *> Arrays;
+  for (ScopArrayInfo *Array : S.arrays())
----------------
[Suggestion] `SmallVector` and/or `reserve()`?


================
Comment at: lib/CodeGen/IRBuilder.cpp:67
+  for (ScopArrayInfo *Array : S.arrays())
+    if (Array->isArrayKind())
+      Arrays.push_back(Array);
----------------
[Followup] Is it easily possible to determine whether there are uses of this Array left in the SCoP (e.g. MaximalStaticExpander would remove all uses of an array and replace it to another; no need to generate metadata for the old one)


https://reviews.llvm.org/D37028