[PATCH] D35918: [GVNHoist] Factor out reachability to search for anticipable instructions quickly

[Daniel Berlin via Phabricator via llvm-commits]

dberlin added a comment.

I think this is mostly reasonable at this point.
If you clean up the naming so it matches the style guide (IE you have a lot of things ending in T for no reason, etc), i'll approve it.



================
Comment at: lib/Transforms/Scalar/GVNHoist.cpp:87
+typedef DenseMap<const BasicBlock *, bool> BBSideEffectsSet;
+typedef std::pair<BasicBlock *, BasicBlock *> PairBB;
+typedef SmallVector<Instruction *, 4> SmallVecInsn;
----------------
This is unused


================
Comment at: lib/Transforms/Scalar/GVNHoist.cpp:90
+typedef SmallVectorImpl<Instruction *> SmallVecImplInsn;
+typedef DenseMap<BasicBlock *, PairBB> PDomMapT;
+// Each element of a hoisting list contains the basic block where to hoist and
----------------
This is unused


================
Comment at: lib/Transforms/Scalar/GVNHoist.cpp:305
+  DenseSet<const BasicBlock *> HoistBarrier;
+  // PDomMapT PDomMap;
+
----------------
This is unused


https://reviews.llvm.org/D35918