[PATCH] D35945: [ELF] - Linkerscript: better diagnostic for INPUT/GROUP commands.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 22 11:35:19 PDT 2017


grimar added inline comments.


================
Comment at: ELF/ScriptParser.cpp:253
 
 void ScriptParser::addFile(StringRef S) {
+  if (S.startswith("/")) {
----------------
Will it be better if I add following check here ?

```
if (ErrorCount)
  return;
```

It still will be excessive check currently I believe (like I pointed in my previous comment), 
but if code outside will change so that this function be called with `ErrorCount > 0`,
such check will protect error reporting logic this patch introduces.




https://reviews.llvm.org/D35945





More information about the llvm-commits mailing list