[PATCH] D36993: [llvm-dwarfdump] Print type names in DW_AT_type DIEs

[Paul Robinson via Phabricator via llvm-commits]

probinson requested changes to this revision.
probinson added a comment.
This revision now requires changes to proceed.

We like to have the original source available for tests like this, ideally with commands to regenerate it.  That practice helps people to understand the test and makes it easier to accommodate any syntactic changes that might come along (although that's more the case with IR tests than assembler tests).



================
Comment at: test/tools/llvm-dwarfdump/X86/verify_type_names.s:6
+# CHECK: DW_TAG_class_type
+# CHECK: DW_AT_type {{.*}} "int"
+# CHECK: DW_TAG_formal_parameter
----------------
The DW_AT_type is on the member, not the class type.


================
Comment at: test/tools/llvm-dwarfdump/X86/verify_type_names.s:10
+# CHECK: DW_TAG_subprogram
+# CHECK: DW_AT_type {{.*}} "int"
+# CHECK: DW_TAG_pointer_type
----------------
Seems like it would be simpler to have one subprogram with a return type and a formal parameter, rather than two subprograms.
I'd also like to see what happens with a type more exciting than "int".


Repository:
  rL LLVM

https://reviews.llvm.org/D36993