[PATCH] D17080: [LAA] Allow more run-time alias checks by coercing pointer expressions to AddRecExprs

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:614
 
 /// \brief Check whether a pointer can participate in a runtime bounds check.
 static bool hasComputableBounds(PredicatedScalarEvolution &PSE,
----------------
Please add a comment on what Assume means in practice for this function.


================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:753
+    if (NeedsCheck && !CanDoAliasSetRT) {
+      // Reset the CanDoSetRt flag and retry all accesses that have failed.
+      CanDoAliasSetRT = true;
----------------
Can you extend this comment to note why, even if they failed previously, they might succeed now.


https://reviews.llvm.org/D17080