[PATCH] D36916: Associate functions with address spaces

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 20 20:08:26 PDT 2017


pcc added inline comments.


================
Comment at: include/llvm/IR/DerivedTypes.h:106
+  FunctionType(Type *Result, ArrayRef<Type*> Params, bool IsVarArgs,
+               unsigned AddrSpace);
 
----------------
I don't understand why this needs to be part of the function type. It seems to me that this ought to work in the same way as for global variables, i.e. function takes an address space at construction time which is used to create its pointer type; address space is queried by querying address space on the pointer type.


https://reviews.llvm.org/D36916





More information about the llvm-commits mailing list