[PATCH] D36647: [Polly][WIP] Scalar fully indexed expansion

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/MaximalStaticExpansion/working_deps_between_inners_phi.ll:33
+;
+; CHECK-DAG: double MemRef_A_Stmt_for_body11_expanded[10000][10000][10000]; // Element size 8
+; CHECK-DAG: double MemRef_add16_lcssa__phi_Stmt_for_inc25_expanded[10000][10000]; // Element size 8
----------------
niosega wrote:
> The arrays are not always coming in the same order. Is there a better solution than CHECK-DAG to handle such checks ?
If there is an indeterminism, we should make it deterministic. Most ofthen this is because we are using some DenseMap or DenseMap whose iteration order depends on memory addresses. We most commonly resolve this be replacing them by a `MapVector`/`SetVector`.

In this case, `ArrayInfoSetTy` is already a `SetVector`. Maybe it is where the elements are added.

Fixing that would be nice, but not required.


https://reviews.llvm.org/D36647