[PATCH] D35621: X86 Asm can't work properly with symbolic Scale

coby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 20 06:11:00 PDT 2017


coby added a comment.

In https://reviews.llvm.org/D35621#845237, @avt77 wrote:

> > + I'm currently having a patch on review (https://reviews.llvm.org/D36793) which contains most of the intended goals of this one (everything but the new error, afaik), can you verify it answers your needs?
>
> Yes, I see that everything I need here is included in https://reviews.llvm.org/D36793. When are you going to commit it?


as soon as it'll get approved..

> Finally, as I understand I should abandom this review because now it's a part of https://reviews.llvm.org/D36793 (including tests, etc.), right?

indeed. note that your added diagnostics are not part of https://reviews.llvm.org/D36793, so consider adding them afterwards if you still fancy it.


https://reviews.llvm.org/D35621





More information about the llvm-commits mailing list