[PATCH] D36054: Emit only A Single Opt Remark When Inlining

[Sam Elliott via Phabricator via llvm-commits]

lenary updated this revision to Diff 111865.
lenary added a comment.

Add Tests that use NewPM

The only issue here is that the NewPM's inline pass does not emit remarks that say "foo will not be inlined into bar because its definition is unavailable", which seems to be to do with how the inline pass finds candidates to inline (the queue it uses never even admits declaration-only functions). I'm not sure this is a major problem per se, but we should perhaps look at re-adding this functionality later.


https://reviews.llvm.org/D36054

Files:
  include/llvm/Analysis/InlineCost.h
  lib/Transforms/IPO/Inliner.cpp
  test/LTO/Resolution/X86/diagnostic-handler-remarks-with-hotness.ll
  test/LTO/Resolution/X86/diagnostic-handler-remarks.ll
  test/LTO/X86/diagnostic-handler-remarks-with-hotness.ll
  test/LTO/X86/diagnostic-handler-remarks.ll
  test/ThinLTO/X86/diagnostic-handler-remarks-with-hotness.ll
  test/ThinLTO/X86/diagnostic-handler-remarks.ll
  test/Transforms/Inline/optimization-remarks-passed-yaml.ll
  test/Transforms/Inline/optimization-remarks-with-hotness.ll
  test/Transforms/Inline/optimization-remarks-yaml.ll
  test/Transforms/Inline/optimization-remarks.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36054.111865.patch
Type: text/x-patch
Size: 19210 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170820/cb7dc657/attachment.bin>