[PATCH] D36929: [GPGPU] Correctly initialize array order and fixed_element information

[Siddharth via Phabricator via llvm-commits]

bollu accepted this revision.
bollu added a comment.
This revision is now accepted and ready to land.

Please add the comment I requested for `cc->isLatestScalarKind() ? isl_bool_true : isl_bool_false;` and the test cases. LGTM.



================
Comment at: test/GPGPU/live-range-reordering-with-privatization.ll:32
+
+; KERNELIR: %private_array = alloca i32
 
----------------
Please add a comment to this test case explaining what it tests now.

```
; This test case now tests the ability to infer that `t` is local to each loop iteration, and can therefore be privatized.
```


================
Comment at: test/GPGPU/scalar-writes-in-scop-requires-abort.ll:19
+
+; Check that we generate a correct "always false" branch.
+; HOST-IR:  br i1 false, label %polly.start, label %loop.pre_entry_bb
----------------
Could you please add the more descriptive comment I had written in the original test case?

```lang=ll,name=comment
; This test case checks that we generate correct code if PPCGCodeGeneration
; decides a build is unsuccessful with invariant load hoisting enabled.
; There is a conditional branch which switches between the original code and
; the new code. We try to set this conditional branch to branch on false.
; However, invariant load hoisting changes the structure of the scop, so we
; need to change the way we *locate* this instruction.
```


https://reviews.llvm.org/D36929