[LNT] r311190 - If no dots are passed, also 400

Chris Matthews via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 18 13:13:54 PDT 2017


Author: cmatthews
Date: Fri Aug 18 13:13:54 2017
New Revision: 311190

URL: http://llvm.org/viewvc/llvm-project?rev=311190&view=rev
Log:
If no dots are passed, also 400

I noticed someone passed a malformed plot tuple that crashed LNT instead
of returning a 400 because they passed a 4 tuple of values. Any
problem with the plot specifier should be a 400 error.

Modified:
    lnt/trunk/lnt/server/ui/views.py

Modified: lnt/trunk/lnt/server/ui/views.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/ui/views.py?rev=311190&r1=311189&r2=311190&view=diff
==============================================================================
--- lnt/trunk/lnt/server/ui/views.py (original)
+++ lnt/trunk/lnt/server/ui/views.py Fri Aug 18 13:13:54 2017
@@ -710,8 +710,8 @@ def v4_graph():
             continue
 
         # Ignore the extra part of the key, it is unused.
-        machine_id_str, test_id_str, field_index_str = value.split('.')
         try:
+            machine_id_str, test_id_str, field_index_str = value.split('.')
             machine_id = int(machine_id_str)
             test_id = int(test_id_str)
             field_index = int(field_index_str)




More information about the llvm-commits mailing list