[PATCH] D36844: [PGO] Fixed assertion due to mismatched memcpy size type.

[Ana Pazos via Phabricator via llvm-commits]

apazos updated this revision to Diff 111706.
apazos marked 2 inline comments as done.
apazos edited the summary of this revision.
apazos added a comment.

Added assert message.


https://reviews.llvm.org/D36844

Files:
  lib/Transforms/Instrumentation/PGOMemOPSizeOpt.cpp
  test/Transforms/PGOProfile/memop_clone.ll


Index: test/Transforms/PGOProfile/memop_clone.ll
===================================================================
--- /dev/null
+++ test/Transforms/PGOProfile/memop_clone.ll
@@ -0,0 +1,27 @@
+; RUN: opt < %s -pgo-memop-opt -S | FileCheck %s
+
+define i32 @test(i8* %a, i8* %b) !prof !1 {
+; CHECK_LABEL: test
+; CHECK: MemOP.Case.3:
+; CHECK: tail call void @llvm.memcpy.p0i8.p0i8.i32(i8* undef, i8* %a, i32 3, i32 1, i1 false)
+; CHECK: MemOP.Case.2:
+; CHECK: tail call void @llvm.memcpy.p0i8.p0i8.i32(i8* undef, i8* %a, i32 2, i32 1, i1 false)
+; CHECK: MemOP.Default:
+; CHECK: tail call void @llvm.memcpy.p0i8.p0i8.i32(i8* undef, i8* %a, i32 undef, i32 1, i1 false)
+; CHECK: MemOP.Case.33:
+; CHECK: tail call void @llvm.memcpy.p0i8.p0i8.i64(i8* undef, i8* %b, i64 3, i32 1, i1 false)
+; CHECK  MemOP.Case.24:
+; CHECK: tail call void @llvm.memcpy.p0i8.p0i8.i64(i8* undef, i8* %b, i64 2, i32 1, i1 false)
+; CHECK: MemOP.Default2:
+; CHECK: tail call void @llvm.memcpy.p0i8.p0i8.i64(i8* undef, i8* %b, i64 undef, i32 1, i1 false)
+  tail call void @llvm.memcpy.p0i8.p0i8.i32(i8* undef, i8* %a, i32 undef, i32 1, i1 false), !prof !2
+  tail call void @llvm.memcpy.p0i8.p0i8.i64(i8* undef, i8* %b, i64 undef, i32 1, i1 false), !prof !2
+  unreachable
+}
+
+declare void @llvm.memcpy.p0i8.p0i8.i32(i8* nocapture writeonly, i8* nocapture readonly, i32, i32, i1)
+declare void @llvm.memcpy.p0i8.p0i8.i64(i8* nocapture writeonly, i8* nocapture readonly, i64, i32, i1)
+
+!1 = !{!"function_entry_count", i64 5170}
+!2 = !{!"VP", i32 1, i64 2585, i64 3, i64 1802, i64 2, i64 783}
+
Index: lib/Transforms/Instrumentation/PGOMemOPSizeOpt.cpp
===================================================================
--- lib/Transforms/Instrumentation/PGOMemOPSizeOpt.cpp
+++ lib/Transforms/Instrumentation/PGOMemOPSizeOpt.cpp
@@ -361,12 +361,15 @@
   DEBUG(dbgs() << "\n\n== Basic Block After==\n");
 
   for (uint64_t SizeId : SizeIds) {
-    ConstantInt *CaseSizeId = ConstantInt::get(Type::getInt64Ty(Ctx), SizeId);
     BasicBlock *CaseBB = BasicBlock::Create(
         Ctx, Twine("MemOP.Case.") + Twine(SizeId), &Func, DefaultBB);
     Instruction *NewInst = MI->clone();
     // Fix the argument.
-    dyn_cast<MemIntrinsic>(NewInst)->setLength(CaseSizeId);
+    MemIntrinsic * MemI = dyn_cast<MemIntrinsic>(NewInst);
+    IntegerType *SizeType = dyn_cast<IntegerType>(MemI->getLength()->getType());
+    assert(SizeType && "Expected integer type size argument.");
+    ConstantInt *CaseSizeId = ConstantInt::get(SizeType, SizeId);
+    MemI->setLength(CaseSizeId);
     CaseBB->getInstList().push_back(NewInst);
     IRBuilder<> IRBCase(CaseBB);
     IRBCase.CreateBr(MergeBB);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36844.111706.patch
Type: text/x-patch
Size: 2678 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170818/39b981f3/attachment.bin>