[PATCH] D36683: [test-suite] Adding miniFE Benchmark

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 18 10:48:20 PDT 2017


MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

LGTM (nitpicks below).



================
Comment at: LICENSE.TXT:87
 XSBench:            llvm-test/MultiSource/Benchmarks/DOE-ProxyApps-C/XSBench
+miniFE:              llvm-test/MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE
 Fhourstones:        llvm-test/MultiSource/Benchmarks/Fhourstones
----------------
indentation seems off


================
Comment at: MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/CMakeLists.txt:2
+set(PROG miniFE)
+list(APPEND CXXFLAGS "-I." "-DMINIFE_SCALAR=double"  "-DMINIFE_LOCAL_ORDINAL=int" "-DMINIFE_GLOBAL_ORDINAL=int" "-DMINIFE_CSR_MATRIX")
+list(APPEND LDFLAGS -lm)
----------------
should work as well without quoting the flags.


https://reviews.llvm.org/D36683





More information about the llvm-commits mailing list