[PATCH] D36874: [ELF] - Mention "-z notext" and -fPIC in some error messages

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

I think that this is a worthwhile addition, I've seen at least a couple of questions on llvm-dev that this improvement might have helped to resolve.



================
Comment at: ELF/Relocations.cpp:570
+        "\n>>> Unintentional use of such relocations is undesirable, and not "
+        "\n>>> permited by default, consider using -z notext.";
     error("can't create dynamic relocation " + toString(Type) + " against " +
----------------
Typo: permited should be permitted.

We may want a bit more context with the -z notext option as well as to someone unfamiliar with the options could be a compiler or a linker option, and it isn't clear from the name what it will actually do. May I suggest something like:
"Unintentional use of such relocations is undesirable, and is not permitted by default, use linker option -z notext to allow.", not a strong opinion though.


https://reviews.llvm.org/D36874