[PATCH] D36791: [Polly][Bug fix] Wrong dependences filtering during Fully Indexed expansion

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added a comment.

Andreas, are you going to commit this?



================
Comment at: lib/Transform/MaximalStaticExpansion.cpp:166
+
+        // Filter out Statement to Statement dependences.
+        if (!Map.can_curry())
----------------
niosega wrote:
> Meinersbur wrote:
> > niosega wrote:
> > > Meinersbur wrote:
> > > > Why? How can this happen?
> > > I don't know why but when I am asking AL_Reference or AL_Access dependencies, I also get Statement to Statement dependencies in the union_map. So I need to filter these out. Am I doing something wrong in the dependencies retrieval call ?
> > I think this is due to the broken dependency info in case there are reduction candidates. Did you switch off reduction detection?
> With -polly-dependences-use-reductions=false in the opt command line, I still have the Statement to Statement dependencies.
> 
Can you check whether these are the same as the reference-level dependencies (i.e. without the tag)?

In any case, AL_Access and AL_Reference are very broken. We'll have to fix that one day.


https://reviews.llvm.org/D36791