[PATCH] D36791: [Polly][Bug fix] Wrong dependences filtering during Fully Indexed expansion

Bonfante Nicolas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 18 06:52:51 PDT 2017


niosega added inline comments.


================
Comment at: lib/Transform/MaximalStaticExpansion.cpp:166
+
+        // Filter out Statement to Statement dependences.
+        if (!Map.can_curry())
----------------
Meinersbur wrote:
> Why? How can this happen?
I don't know why but when I am asking AL_Reference or AL_Access dependencies, I also get Statement to Statement dependencies in the union_map. So I need to filter these out. Am I doing something wrong in the dependencies retrieval call ?


================
Comment at: lib/Transform/MaximalStaticExpansion.cpp:175-176
+
+        auto TmpMap = Map.curry().range().wrapped_domain_map().curry();
+        auto TmpMapDomainId = TmpMap.domain().get_tuple_id();
+
----------------
Meinersbur wrote:
> [Suggestion] Do this on `Map.get_space()`, so the projections don't need to be computed.
What is the best solution to get the Id between these two solutions ?

```
Map.get_space().domain().unwrap().range() 
```

```
Map.get_space().curry().range().unwrap().domain()
```



https://reviews.llvm.org/D36791





More information about the llvm-commits mailing list