[PATCH] D36866: [ARM] Add PostRAScheduling option

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 18 03:29:14 PDT 2017


samparker added inline comments.


================
Comment at: lib/Target/ARM/ARM.td:876
+                                                         FeatureHasNoBranchPredictor,
+                                                         FeaturePostRAScheduler]>;
 
----------------
fhahn wrote:
> What's the reason for adding `FeaturePostRAScheduler` to some processors but not others? 
> 
> It seems to be a nonfunctional change, because all changed processors seem to have FeatureThumb2, so `enablePostRAScheduler` would return true anyways.
I've added them to the processors that my team is currently tracking the performance of. If we want to develop some downstream schedulers and use the machine scheduler, it easily allows us to use post RA as well. Even though this can be defined in the SchedModel, I wanted to keep some consistency with your previous patch and the approach of AArch64.


https://reviews.llvm.org/D36866





More information about the llvm-commits mailing list