[PATCH] D36615: [XRay][CodeGen] Use PIC-friendly code in XRay sleds; remove synthetic references in .text

[Dean Michael Berris via Phabricator via llvm-commits]

dberris marked 2 inline comments as done.
dberris added a comment.

Thanks, @pcc -- PTAL?



================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2823-2828
+  if (MF->getSubtarget().getTargetTriple().isOSBinFormatELF()) {
+    OutStreamer->EmitSymbolAttribute(SledsStart, MCSymbolAttr::MCSA_Hidden);
+    OutStreamer->EmitSymbolAttribute(SledsStart, MCSymbolAttr::MCSA_Local);
+    OutStreamer->EmitSymbolAttribute(SledsStart,
+                                     MCSymbolAttr::MCSA_ELF_TypeNoType);
+  }
----------------
dblaikie wrote:
> Repetitious - reformat to a common function, perhaps?
Looks like we didn't need to do that anyway, removed.


https://reviews.llvm.org/D36615