[PATCH] D36556: [IR] AutoUpgrade ModuleFlagBehavior for PIC and PIE level

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 17 11:50:41 PDT 2017


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

Sorry for the delay, I was out all last week and missed this one. LGTM but with one question below about a test change.



================
Comment at: test/Linker/module-flags-pic-1-a.ll:5
 
-!0 = !{ i32 1, !"PIC Level", i32 1 }
+!0 = !{ i32 7, !"PIC Level", i32 1 }
 
----------------
Does this need to change - i.e. with this patch shouldn't it auto-upgrade?


https://reviews.llvm.org/D36556





More information about the llvm-commits mailing list