[PATCH] D36758: [LLD COFF / PDB] Incrementally update the BuildId when writing a PDB.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 16 14:20:51 PDT 2017


thakis added inline comments.


================
Comment at: lld/trunk/COFF/Writer.cpp:237
+// fail, so the symbol cache knows to use the new PDB, but the GUID matches, so
+// it overwrites the existing item in the symbol cache rather than making a new
+// one.
----------------
Could this talk about build determinism a bit? rnk mentioned that upthread.

Is there a list of all sources of build indeterminism in lld? Deterministic builds is one of the motivations for the whole clang-cl thing, so it'd be good if we had a list of things needed to get there :-)


Repository:
  rL LLVM

https://reviews.llvm.org/D36758





More information about the llvm-commits mailing list