[PATCH] D36705: Avoid creating duplicate ANDs in SelectionDAG.

John Brawn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 16 07:45:38 PDT 2017


john.brawn added inline comments.


================
Comment at: test/CodeGen/ARM/wide-compares.ll:39-44
-  ; CHECK-ARM: movwge r12, #1
-  ; CHECK-ARM: cmp r12, #0
-  ; CHECK-THUMB2: movge.w r12, #1
-  ; CHECK-THUMB: cmp.w r12, #0
-  ; CHECK: bne [[BB2:\.[0-9A-Za-z_]+]]
   br i1 %cmp, label %bb1, label %bb2
----------------
This looks strange - in latest trunk the test is already expecting a bge here. In fact according to svn log wide-compares.ll hasn't changed since the initial commit which already expected bge. Are you sure this patch is for trunk llvm?


https://reviews.llvm.org/D36705





More information about the llvm-commits mailing list