[PATCH] D34566: [loop idiom Recognition] support memcpy for multiple consecutive loads and stores

[DIVYA SHANMUGHAN via Phabricator via llvm-commits]

DIVYA added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopIdiomRecognize.cpp:143
+                               bool NegStride, LegalStoreKind MemIdiom,
+                               bool IsLoopMemset = false);
+
----------------
haicheng wrote:
> I think we should use MemIdiom and IsLoopMemset can be removed.
But when processLoopStridedStore() is called from processLoopMemSet() function , then IsLoopMemset is set true and when it is called from processLoopStores() function , then  IsLoopMemset is set false.Even though both can have MemIdiom set to LegalStoreKind::Memset .So using MemIdiom alone would not be sufficient.As, we need IsLoopMemset to indicate if memset which can be promoted to a large memset.


https://reviews.llvm.org/D34566