[PATCH] D36683: [test-suite] Adding miniFE Benchmark

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 14:43:06 PDT 2017


MatzeB requested changes to this revision.
MatzeB added a comment.
This revision now requires changes to proceed.

- I'd like to hear more comments on the license (see below).
- Integration looks good to me
- Maybe put the benchmark descriptions in a README file into the benchmark directory



================
Comment at: MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/Box.hpp:7-8
+//
+// Under terms of Contract DE-AC04-94AL85000, there is a non-exclusive
+// license for use of this work by or on behalf of the U.S. Government.
+//
----------------
This sentence feels odd and I wonder how this would be compatible with the LGPL statements following it.

Can you clarify this or drop them?


https://reviews.llvm.org/D36683





More information about the llvm-commits mailing list