[PATCH] D36728: Switch to consumeError(), since this can crash otherwise.

Stephen Hines via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 14:21:49 PDT 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rL310958: Switch to consumeError(), since this can crash otherwise. (authored by srhines).

Repository:
  rL LLVM

https://reviews.llvm.org/D36728

Files:
  cfe/trunk/lib/Tooling/Core/Replacement.cpp


Index: cfe/trunk/lib/Tooling/Core/Replacement.cpp
===================================================================
--- cfe/trunk/lib/Tooling/Core/Replacement.cpp
+++ cfe/trunk/lib/Tooling/Core/Replacement.cpp
@@ -503,7 +503,7 @@
                                             std::string(R.getLength(), ' ')));
     assert(!Err &&
            "Replacements must not conflict since ranges have been merged.");
-    (void)Err;
+    llvm::consumeError(std::move(Err));
   }
   return FakeReplaces.merge(Replaces).getAffectedRanges();
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36728.111255.patch
Type: text/x-patch
Size: 535 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170815/1e630da5/attachment.bin>


More information about the llvm-commits mailing list