[PATCH] D36758: [LLD COFF / PDB] Incrementally update the BuildId when writing a PDB.

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: lld/COFF/Writer.cpp:799
+  auto Binary = std::move(*ExpectedExe);
+  if (!Binary.getBinary()->isCOFF())
+    return;
----------------
compnerd wrote:
> When would this be false?  I thought that `link` is never used as a resource compiler, and you use `resgen` for that.
If the output file exists on disk but is just a random text file, for example.


================
Comment at: lld/COFF/Writer.cpp:809
+  // of the existing binary, don't try to re-use the build id.
+  if (File.is64() != Config->is64())
+    return;
----------------
compnerd wrote:
> Is the bitsex enough?  Shouldn't we check the machine and the bitsex?
Ahh yes, I suppose you could be writing an intel x86-64 binary and the existing binary on disk is arm64 or something.  We shouldn't re-use the build id in that case either.


https://reviews.llvm.org/D36758