[PATCH] D36201: Merge manifest namespaces.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/lib/WindowsManifest/WindowsManifestMerger.cpp:283-284
+    return true;
+  else
+    return false;
+}
----------------
ruiu wrote:
> `else` after `return`
This can be just `return hasInheritedNs(Node) && Node->ns->prefix == nullptr;`


================
Comment at: llvm/lib/WindowsManifest/WindowsManifestMerger.cpp:289
+static bool hasDefinedDefaultNamespace(xmlNodePtr Node) {
+  if (Node->ns && (Node->ns == getNamespaceWithPrefix(nullptr, Node)))
+    return true;
----------------
ditto, you can return the condition.


https://reviews.llvm.org/D36201