[PATCH] D36758: [LLD COFF / PDB] Incrementally update the BuildId when writing a PDB.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 13:23:38 PDT 2017


rnk added a comment.

In https://reviews.llvm.org/D36758#842342, @ruiu wrote:

> I think it is more straightforward if you change Writer::writeBuildId to compute a hash using not only an executable but also a pdb file. If you do that, every time debug info is different, you'll get a different build id, which I think solves the issue.
>
> That way, we can still maintain build reproducibility. I don't want to use a random value as a build id.


PDB files are too big. I don't want to MD5 4GB of data just to avoid a random number.

My suggestion for people that want determinstic builds is that we ask them to pass a flag like `/PDBGUID:XXXXXX-XXX-XX`. Then it's completely out of our hands.


https://reviews.llvm.org/D36758





More information about the llvm-commits mailing list