[PATCH] D36758: [LLD COFF / PDB] Incrementally update the BuildId when writing a PDB.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 11:17:25 PDT 2017


ruiu added a comment.

I think it is more straightforward if you change Writer::writeBuildId to compute a hash using not only an executable but also a pdb file. If you do that, every time debug info is different, you'll get a different build id, which I think solves the issue.

That way, we can still maintain build reproducibility. I don't want to use a random value as a build id.


https://reviews.llvm.org/D36758





More information about the llvm-commits mailing list