[PATCH] D36628: [test-suite]: Adding Lulesh Proxy-app

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: MultiSource/Benchmarks/DOE-ProxyApps-C++/lulesh/lulesh-init.cc:420
+	 //pick the region
+	 regionVar = rand() % costDenominator;
+	 Index_t i = 0;
----------------
This also depends on rand. See my comments on this in D36621 and D36626.


================
Comment at: MultiSource/Benchmarks/DOE-ProxyApps-C/RSBench.patch:127
++RSBench:            llvm-test/MultiSource/Benchmarks/DOE-ProxyApps-C/RSBench
+diff --git a/MultiSource/Benchmarks/DOE-ProxyApps-C/CMakeLists.txt b/MultiSource/Benchmarks/DOE-ProxyApps-C/CMakeLists.txt
+index 05091785..ec2ba90a 100644
----------------
Something's wrong here. You have a patch in a patch somehow.


https://reviews.llvm.org/D36628