[PATCH] D36311: [ThinLTO] Add GraphTraits for FunctionSummaries

Charles Saternos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 07:29:46 PDT 2017


ncharlie marked an inline comment as done.
ncharlie added inline comments.


================
Comment at: include/llvm/IR/ModuleSummaryIndex.h:838
+    // (since scc_iterator doesn't accept nullptrs)
+    auto F = llvm::make_unique<FunctionSummary>(
+        FunctionSummary::GVFlags(
----------------
This is causing problems. The scc_iterator gets stuck on these functionsummaries since they're not in the original graph, which causes it to terminate before going through all the SCCs in the summary callgraph.


https://reviews.llvm.org/D36311





More information about the llvm-commits mailing list