[PATCH] D36722: [InlineCost] Simplify the cold attribute handling in inline-cost.

Easwaran Raman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 19:19:27 PDT 2017


eraman added a comment.

LGTM. Not handling the cold attribute was an oversight and when the callee is marked cold, it makes sense to treat all its callsites as cold (therefore reasonable to handle in isColdCallsite). I also agree with collapsing the two similar params with the same value until we see a need to have different default values for them.


https://reviews.llvm.org/D36722





More information about the llvm-commits mailing list