[PATCH] D36722: [InlineCost] Simplify the cold attribute handling in inline-cost.

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/Analysis/InlineCost.cpp:659
+  // should *always* be considered cold.
+  if (Callee.hasFnAttribute(Attribute::Cold))
+    return true;
----------------
chandlerc wrote:
> davidxl wrote:
> > IIRC, static branch prediction already handles this case. Do you see missing cases?
> Sorry, I tried to explain in my top-level description -- there are cases where despite being cold, the call site won't be cold relative to the function entry. For example, when the call site is *in* the function entry block.
> 
> Maybe this still isn't making sense? I can add an example bit of code.
There is an inconsistency between cold callsite relative freq and the cold branch probability --- it is 6% vs 2%. I think we should fix one of them -- IMO, it is more reasonable to fix the static branch prediction.




https://reviews.llvm.org/D36722