[PATCH] D35890: [Diagnostics][Inline-Asm]Allow targets to provide elaborations regarding failures resulted from (GNU-inline-asm) modifiers' apply

[coby via Phabricator via llvm-commits]

coby added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp:275-276
         Msg << "invalid operand in inline asm: '" << AsmStr << "'";
+        if (!ErrorMsg.empty())
+          Msg << ErrorMsg;
         MMI->getModule()->getContext().emitError(LocCookie, Msg.str());
----------------
arsenm wrote:
> I would expect this does the right thing anyway if you just << ErrorMsg even when empty
You right, thx.
will update


Repository:
  rL LLVM

https://reviews.llvm.org/D35890