[PATCH] D36619: [MachineCombiner] Update instruction depths incrementally for large BBs.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 09:54:50 PDT 2017


fhahn updated this revision to Diff 111016.
fhahn retitled this revision from "[MachineCombine] Update instruction depths incrementally." to "[MachineCombiner] Update instruction depths incrementally for large BBs.".
fhahn edited the summary of this revision.
fhahn added a reviewer: efriedma.
fhahn added a comment.
Herald added a subscriber: javed.absar.

Thanks for your feedback Eli. I've update the patch to only use incremental updates if the size of a BB is over a certain threshold. I've chosen 500 instructions for now, but a slightly higher one would probably be OK too.

I've also updated the patch to take the LiveRegUnits into account when doing incremental updates. Also, the code to compute the incremental info is only executed if we found viable patterns.


https://reviews.llvm.org/D36619

Files:
  lib/CodeGen/MachineCombiner.cpp
  test/CodeGen/AArch64/machine-combiner.ll
  test/CodeGen/X86/machine-combiner.ll
  test/CodeGen/X86/mul-constant-result.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36619.111016.patch
Type: text/x-patch
Size: 12422 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170814/5f71eac2/attachment.bin>


More information about the llvm-commits mailing list