[PATCH] D36480: [LLVM] Change to Verifier to allow Fortran CHARACTER types in debug information

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

What I was getting at was that if you are planning to support variable-length strings with a DW_AT_string_length attribute anytime in the near future, then it would be best to think about this now so we don't have to migrate the string representation later when it becomes necessary. Otherwise I'm fine with either:

1. representing Fortran strings as DIDerivedType (with the extra base type displaying the encoding)
2. representing them as DICompositeType (similar to arrays)

Note that the second option may be interesting because of the fact that IIRC Fortran supports also variable-length arrays with a length (and for assumed-rank arrays even a dimensionality) field that has to be represented in LLVM debug info metadata similarly to the length of the string.

Form your last reply I was not quite sure whether you prefer either of these options or if you think that they are both unsuitable, so please let me know what you think about this.


https://reviews.llvm.org/D36480