[PATCH] D36669: Build LLVM with -Wstrict-prototypes enabled

[Alex L via llvm-commits]

On 14 August 2017 at 16:40, Duncan P. N. Exon Smith <dexonsmith at apple.com>
wrote:

>
>
> On Aug 14, 2017, at 08:39, Alex L <arphaman at gmail.com> wrote:
>
>
>
> On 14 August 2017 at 16:19, Duncan P. N. Exon Smith via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Should this be part of -Wextra?
>>
>
> Do you mean the flag itself or LLVM's compilation?
>
>
> I meant the flag itself.
>

FWIW it doesn't look like GCC puts it in -Wextra. Not sure if Clang should
or not though.


>
> LLVM doesn't use -Wextra right now AFAIK.
>
>
> Oh, interesting.
>
>
>
>>
>> > On Aug 14, 2017, at 04:13, Alex Lorenz via Phabricator <
>> reviews at reviews.llvm.org> wrote:
>> >
>> > arphaman created this revision.
>> > Herald added a subscriber: mgorny.
>> >
>> > Clang 5 supports -Wstrict-prototypes. We should use it to catch any C
>> declarations that declare a non-prototype function.
>> >
>> >
>> > Repository:
>> >  rL LLVM
>> >
>> > https://reviews.llvm.org/D36669
>> >
>> > Files:
>> >  cmake/modules/HandleLLVMOptions.cmake
>> >  projects/compiler-rt/lib/profile/GCDAProfiling.c
>> >  projects/compiler-rt/lib/profile/InstrProfiling.h
>> >  projects/compiler-rt/lib/profile/InstrProfilingFile.c
>> >  projects/compiler-rt/lib/profile/InstrProfilingInternal.h
>> >  projects/compiler-rt/lib/profile/InstrProfilingUtil.h
>> >  projects/libunwind/src/config.h
>> >  projects/libunwind/src/unwind_ext.h
>> >
>> > <D36669.110939.patch>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170814/e1cffe7c/attachment.html>