[llvm] r310846 - [X86] Fix a place that was mishandling X86ISD::UMUL.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 08:32:40 PDT 2017


Author: ctopper
Date: Mon Aug 14 08:32:40 2017
New Revision: 310846

URL: http://llvm.org/viewvc/llvm-project?rev=310846&view=rev
Log:
[X86] Fix a place that was mishandling X86ISD::UMUL.

According to the X86ISelLowering.h, UMUL results are low, high, and flags. But this place was treating result 1 or 2 as flags.

Differential Revision: https://reviews.llvm.org/D36654

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=310846&r1=310845&r2=310846&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Mon Aug 14 08:32:40 2017
@@ -17604,7 +17604,7 @@ static bool isX86LogicalCmp(SDValue Op)
     return true;
   if (Op.getResNo() == 1 &&
       (Opc == X86ISD::ADD || Opc == X86ISD::SUB || Opc == X86ISD::ADC ||
-       Opc == X86ISD::SBB || Opc == X86ISD::SMUL || Opc == X86ISD::UMUL ||
+       Opc == X86ISD::SBB || Opc == X86ISD::SMUL ||
        Opc == X86ISD::INC || Opc == X86ISD::DEC || Opc == X86ISD::OR ||
        Opc == X86ISD::XOR || Opc == X86ISD::AND))
     return true;




More information about the llvm-commits mailing list