[PATCH] D31220: [builtins][ARM] Select correct code fragments when compiling for Thumb1/Thum2/ARM ISA

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

Please adjust the comment and remove the CMake change prior to committing this.



================
Comment at: lib/builtins/assembly.h:90
+#define ITE(cond)
+#endif // end of defined(__thumb__2)
+#else // !defined(__thumb2__) && !defined(__thumb__)
----------------
Use:
    // defined(__thumb2__)


================
Comment at: test/asan/CMakeLists.txt:10
 set(SHADOW_MAPPING_UNRELIABLE FALSE)
-if(OS_NAME MATCHES "Windows" AND CMAKE_SIZEOF_VOID_P EQUAL 8 AND
-    ${CMAKE_SYSTEM_VERSION} LESS 6.2)
----------------
peter.smith wrote:
> I'm in no position to judge whether removing this is the right thing to do, but I can't immediately see how it is related to this patch?
This shouldn't be part of this patch.


https://reviews.llvm.org/D31220