[PATCH] D36335: Add ‘llvm.experimental.constrained.fma‘ Intrinsic

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: test/CodeGen/X86/fp-intrinsics.ll:2
 ; RUN: llc -O3 -mtriple=x86_64-pc-linux < %s | FileCheck %s
+; RUN: llc -O3 -mtriple=x86_64-pc-linux -mattr=+fma < %s | FileCheck --check-prefix=FMA64 %s
 
----------------
Missing -check-prefix=CHECK


================
Comment at: test/CodeGen/X86/fp-intrinsics.ll:246
+; CHECK-LABEL: f17
+; CHECK: jmp fma  # TAILCALL
+; FMA64: vfmadd213sd
----------------
You need a separate check-label for the FMAless run line


================
Comment at: test/Feature/fp-intrinsics.ll:244
+}
+
 @llvm.fp.env = thread_local global i8 zeroinitializer, section "llvm.metadata"
----------------
Should also test for the other FP types


Repository:
  rL LLVM

https://reviews.llvm.org/D36335