[PATCH] D36335: Add ‘llvm.experimental.constrained.fma‘ Intrinsic

Brian Sumner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 14:08:51 PDT 2017


b-sumner added inline comments.


================
Comment at: docs/LangRef.rst:13035
+The fourth and fifth arguments specify the rounding mode and exception
+behavior as described above.  The rounding mode argument has no effect, since
+the result of frem is never rounded, but the argument is included for
----------------
Too much cut and paste from frem


================
Comment at: docs/LangRef.rst:13043
+The value produced is the mupliy the two value operands and then add the value of the
+third operand. And the produced result has the same type as the operands.
 
----------------
rounding only once


================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:2017
+    SDValue ISDFMA = CurDAG->getNode(
+    X86ISD::FMADD, SDLoc(Node), Node->getValueType(0), Node->getOperand(0),
+    Node->getOperand(1), Node->getOperand(2));
----------------
Did you run clang-format?


Repository:
  rL LLVM

https://reviews.llvm.org/D36335





More information about the llvm-commits mailing list