[PATCH] D29936: [RISCV 14/n] Support for function calls

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:170
+  if (IsVarArg) {
+    llvm_unreachable("LowerCall with varargs not implemented");
+  }
----------------
report_fatal_error


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:186
+      continue;
+    llvm_unreachable("Passing arguments byval not yet implemented");
+  }
----------------
report_fatal_error


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:207-210
+    if (VA.isRegLoc())
+      // Queue up the argument copies and emit them at the end.
+      RegsToPass.push_back(std::make_pair(VA.getLocReg(), ArgValue));
+    else {
----------------
Please consistently brace.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:212
+      assert(VA.isMemLoc() && "Argument not register or memory");
+      llvm_unreachable("Passing arguments via the stack not yet implemented");
+    }
----------------
report_fatal_error


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:227
+  } else if (isa<ExternalSymbolSDNode>(Callee)) {
+    llvm_unreachable(
+        "lowerExternalSymbol, needed for lowerCall, not yet handled");
----------------
report_fatal_error


https://reviews.llvm.org/D29936