[PATCH] D36490: Enable ASAN on NetBSD

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.


================
Comment at: cmake/config-ix.cmake:487
-if (COMPILER_RT_HAS_SANITIZER_COMMON AND ASAN_SUPPORTED_ARCH AND
-    (NOT OS_NAME MATCHES "NetBSD"))
   set(COMPILER_RT_HAS_ASAN TRUE)
----------------
krytarowski wrote:
> vitalybuka wrote:
> > krytarowski wrote:
> > > vitalybuka wrote:
> > > > krytarowski wrote:
> > > > > vitalybuka wrote:
> > > > > > No sure what does this mean: COMPILER_RT_ASAN_HAS_STATIC_RUNTIME and no COMPILER_RT_HAS_ASAN
> > > > > > 
> > > > > This enables COMPILER_RT_HAS_ASAN and COMPILER_RT_ASAN_HAS_STATIC_RUNTIME on NetBSD.
> > > > But there is **NOT** OS_NAME MATCHES "NetBSD"
> > > This is correct.
> > So I read this as NetBSD will always have COMPILER_RT_HAS_ASAN equal FALSE.
> > How does this enable COMPILER_RT_HAS_ASAN?
> This patch removes this line, not adds it. With removal of this condition (NOT NETBSD), it enables COMPILER_RT_HAS_ASAN.
facepalm
thanks


Repository:
  rL LLVM

https://reviews.llvm.org/D36490