[PATCH] D36575: [ARM] Assembler support for the ARMv8.2a dot product instructions

[Tim Northover via Phabricator via llvm-commits]

t.p.northover added a comment.

> Shouldn't the feature be predicated on HasV8_2aOps, not just NEON? It seems weird, from the tests, that we can target arm or thumbv7 but still have access to these instructions.

They're optional in v8.2a (actually, until I saw the XML I thought they were v8.4) so they need a separate feature. I think those implies fields mostly make sense for the grander features like whole architecture levels; Sjoerd's choice is at least consistent with the FeatureCrypto above.


https://reviews.llvm.org/D36575