[PATCH] D36552: [LVI] Fix LVI compile time regression around constantFoldUser()

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy added inline comments.


================
Comment at: lib/Analysis/LazyValueInfo.cpp:1496
+        ValUsesConditionAndFoldable = usesOperand(Usr, Condition) &&
+            canConstantFoldUser(Usr);
+      if (!ValUsesConditionAndFoldable)
----------------
Shouldn't this be `canConstantFoldUser(Usr) && usesOperand(Usr, Condition)`?  Otherwise we're not really short-circuiting anything.


https://reviews.llvm.org/D36552