[PATCH] D36538: Remove RISCV from LLVM_ALL_TARGETS in CMakeLists.txt

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 12:07:37 PDT 2017


asb created this revision.
Herald added a subscriber: mgorny.

It was mistakenly added to that list in https://reviews.llvm.org/D23560 (committed in https://reviews.llvm.org/rL285712). RISCV is an experimental backend and should never have been in that list, I mistakenly interpreted LLVM_ALL_TARGETS as a list of all targets rather than targets to build by default. Unfortunately, because of this RISCV has been building by default when it shouldn't be.

I have authored a post for llvm-dev with more information on and will update this description to point to that message in a moment.


https://reviews.llvm.org/D36538

Files:
  CMakeLists.txt


Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -309,6 +309,7 @@
 set(LLVM_EXAMPLES_BINARY_DIR ${LLVM_BINARY_DIR}/examples)
 set(LLVM_INCLUDE_DIR ${CMAKE_CURRENT_BINARY_DIR}/include)
 
+# List of all targets to be built by default:
 set(LLVM_ALL_TARGETS
   AArch64
   AMDGPU
@@ -320,7 +321,6 @@
   MSP430
   NVPTX
   PowerPC
-  RISCV
   Sparc
   SystemZ
   X86


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36538.110446.patch
Type: text/x-patch
Size: 444 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170809/36634f7f/attachment.bin>


More information about the llvm-commits mailing list