[PATCH] D36344: [X86] Don't use fsin/fcos/fsincos instructions ever

David Kreitzer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 11:43:08 PDT 2017


DavidKreitzer added a comment.

Just a minor question on the test changes. Otherwise, this LGTM.



================
Comment at: test/CodeGen/X86/sincos-opt.ll:124
+; GNU_SINCOS_FASTMATH: fldt 32(%{{[re]}}sp)
 ; GNU_SINCOS_FASTMATH: faddp %st(1)
   %call = tail call x86_fp80 @sinl(x86_fp80 %x) readnone
----------------
Was moving the check for 'ret' here intentional?


https://reviews.llvm.org/D36344





More information about the llvm-commits mailing list