[PATCH] D36451: [ELF, LinkerScript] Support ! operator in linker script.

[Hafiz Abid Qadeer via Phabricator via llvm-commits]

abidh marked an inline comment as done.
abidh added inline comments.


================
Comment at: test/ELF/linkerscript/assert.s:46
+# RUN: FileCheck %s -check-prefix=FAIL1 < %t.log
+# FAIL1: fail
+
----------------
grimar wrote:
> You can reuse `FAIL` I think.
> 
> ```
> # RUN: FileCheck %s -check-prefix=FAIL < %t.log
> ```
I tried but it was not immediately obvious how to do it.


================
Comment at: test/ELF/linkerscript/symbol-assignexpr.s:18
 # RUN:         symbol12 += 1; \
+# RUN:         symbol13 = !(symbol); \
 # RUN:         bar = 0x5678; \
----------------
grimar wrote:
> All your new testcases using parentheses, is there some problem without them ?
The linker script parsing have problem where it can not separate these operator. You will see that test of ~ operator also use '(' or space in between. I have also changed one test to use space but this needs to be fixed as a separate problem.


https://reviews.llvm.org/D36451