[llvm] r310358 - [PowerPC] Don't crash on larger splats achieved through 1-byte splats

[Nemanja Ivanovic via llvm-commits]

Author: nemanjai
Date: Tue Aug  8 06:52:45 2017
New Revision: 310358

URL: http://llvm.org/viewvc/llvm-project?rev=310358&view=rev
Log:
[PowerPC] Don't crash on larger splats achieved through 1-byte splats

We've implemented a 1-byte splat using XXSPLTISB on P9. However, LLVM will
produce a 1-byte splat even for wider element BUILD_VECTOR nodes. This patch
prevents crashing in that situation.

Differential Revision: https://reviews.llvm.org/D35650

Added:
    llvm/trunk/test/CodeGen/PowerPC/splat-larger-types-as-v16i8.ll
Modified:
    llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp

Modified: llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp?rev=310358&r1=310357&r2=310358&view=diff
==============================================================================
--- llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp Tue Aug  8 06:52:45 2017
@@ -7650,6 +7650,15 @@ SDValue PPCTargetLowering::LowerBUILD_VE
         return DAG.getBitcast(Op.getValueType(), NewBV);
       return NewBV;
     }
+
+    // BuildVectorSDNode::isConstantSplat() is actually pretty smart. It'll
+    // detect that constant splats like v8i16: 0xABAB are really just splats
+    // of a 1-byte constant. In this case, we need to convert the node to a
+    // splat of v16i8 and a bitcast.
+    if (Op.getValueType() != MVT::v16i8)
+      return DAG.getBitcast(Op.getValueType(),
+                            DAG.getConstant(SplatBits, dl, MVT::v16i8));
+
     return Op;
   }
 

Added: llvm/trunk/test/CodeGen/PowerPC/splat-larger-types-as-v16i8.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/PowerPC/splat-larger-types-as-v16i8.ll?rev=310358&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/PowerPC/splat-larger-types-as-v16i8.ll (added)
+++ llvm/trunk/test/CodeGen/PowerPC/splat-larger-types-as-v16i8.ll Tue Aug  8 06:52:45 2017
@@ -0,0 +1,20 @@
+; RUN: llc -mcpu=pwr9 -mtriple=powerpc64-unknown-unknown < %s | FileCheck %s
+; RUN: llc -mcpu=pwr9 -mtriple=powerpc64le-unknown-unknown < %s | FileCheck %s
+define <8 x i16> @test1() {
+entry:
+  ret <8 x i16> <i16 257, i16 257, i16 257, i16 257, i16 257, i16 257, i16 257, i16 257>
+; CHECK-LABEL: test1
+; CHECK: xxspltib 34, 1
+}
+define <8 x i16> @testAB() {
+entry:
+; CHECK-LABEL: testAB
+; CHECK: xxspltib 34, 171
+  ret <8 x i16> <i16 43947, i16 43947, i16 43947, i16 43947, i16 43947, i16 43947, i16 43947, i16 43947>
+}
+define <4 x i32> @testAB32() {
+entry:
+; CHECK-LABEL: testAB32
+; CHECK: xxspltib 34, 171
+  ret <4 x i32> <i32 2880154539, i32 2880154539, i32 2880154539, i32 2880154539>
+}