[PATCH] D36333: Move the SampleProfileLoader right after EarlyFPM.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 11:18:24 PDT 2017


chandlerc accepted this revision.
chandlerc added a comment.

In https://reviews.llvm.org/D36333#833963, @danielcdh wrote:

> ping...
>
> I think Chandler's concerns for this patch has been addressed. We can continue discussion on the AutoFDO design in a separate thread. Will submit the patch by EOD if no more concerns have been raised.


Sorry for delay,

Yes, all I was looking for was a comment so that a reader would better understand what the sample profile loading is doing (IE, transforming the IR). Not trying to suggest that we can or should change behavior here, just getting it more clearly documented. Thanks for that! =D


https://reviews.llvm.org/D36333





More information about the llvm-commits mailing list